Re: [libvirt] [PATCH] virISCSIDirectRefreshVol: Don't clear volumes in each run

2019-02-28 Thread Jiri Denemark
On Thu, Feb 28, 2019 at 15:44:46 +0100, Michal Privoznik wrote: > When fetching LUNs from iscsi server the > virISCSIDirectReportLuns() is called. This function does some > libiscsi calls and then calls virISCSIDirectRefreshVol() over > each LUN found. It's unfortunate that the latter calls > virSt

[libvirt] [PATCH] virISCSIDirectRefreshVol: Don't clear volumes in each run

2019-02-28 Thread Michal Privoznik
When fetching LUNs from iscsi server the virISCSIDirectReportLuns() is called. This function does some libiscsi calls and then calls virISCSIDirectRefreshVol() over each LUN found. It's unfortunate that the latter calls virStoragePoolObjClearVols() as we lose all LUNs processed in previous iteratio