Re: [libvirt] [PATCH] vircapstest: Avoid (im)possible strcmp call with NULL argument

2017-11-14 Thread Michal Privoznik
On 11/13/2017 10:44 PM, Jiri Denemark wrote: > Some compiler may get confused and decide we are calling strcmp with > NULL argument from test_virCapsDomainDataLookupLXC. Although this does > not really happen since the call is guarded with > (data->machinetype != expect_machinetype), using STRNEQ_N

[libvirt] [PATCH] vircapstest: Avoid (im)possible strcmp call with NULL argument

2017-11-13 Thread Jiri Denemark
Some compiler may get confused and decide we are calling strcmp with NULL argument from test_virCapsDomainDataLookupLXC. Although this does not really happen since the call is guarded with (data->machinetype != expect_machinetype), using STRNEQ_NULLABLE is easier to understand, less fragile, and do