Re: [libvirt] [PATCH] virsh: Null terminated the string memcpy from buffer explicitly

2012-06-14 Thread Osier Yang
On 2012年06月14日 19:16, Eric Blake wrote: On 06/14/2012 05:09 AM, Osier Yang wrote: --- tools/virsh.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) A bit light on the commit message. Does this solve an actual crash, or does it just silence an overactive static code analyzer

Re: [libvirt] [PATCH] virsh: Null terminated the string memcpy from buffer explicitly

2012-06-14 Thread Eric Blake
On 06/14/2012 05:09 AM, Osier Yang wrote: > --- > tools/virsh.c |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) A bit light on the commit message. Does this solve an actual crash, or does it just silence an overactive static code analyzer? > > diff --git a/tools/virsh.c b/too

[libvirt] [PATCH] virsh: Null terminated the string memcpy from buffer explicitly

2012-06-14 Thread Osier Yang
--- tools/virsh.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 98305c0..4509020 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -15069,11 +15069,13 @@ cleanup: VIR_FREE(device_type); VIR_FREE(disk_type); if (xml_