Re: [libvirt] [PATCH] virsh: Report error when taking a snapshot with empty --memspec argument

2012-11-22 Thread Peter Krempa
On 11/22/12 12:09, Martin Kletzander wrote: On 11/22/2012 11:03 AM, Peter Krempa wrote: When the value of memspec was empty taking of a snapshot failed without reporting an error. --- tools/virsh-snapshot.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/virsh-

Re: [libvirt] [PATCH] virsh: Report error when taking a snapshot with empty --memspec argument

2012-11-22 Thread Martin Kletzander
On 11/22/2012 11:03 AM, Peter Krempa wrote: > When the value of memspec was empty taking of a snapshot failed without > reporting an error. > --- > This is only a quick fix. I think we should improve vshCommandOptStr to detect > this for us and report an appropriate error, but this change will requ

[libvirt] [PATCH] virsh: Report error when taking a snapshot with empty --memspec argument

2012-11-22 Thread Peter Krempa
When the value of memspec was empty taking of a snapshot failed without reporting an error. --- This is only a quick fix. I think we should improve vshCommandOptStr to detect this for us and report an appropriate error, but this change will require a lot of changes not relevant to this problem. ---