Re: [libvirt] [PATCH] virsh: detect programming errors with option parsing

2013-08-28 Thread Eric Blake
On 08/28/2013 10:31 AM, Michal Privoznik wrote: > On 17.08.2013 00:14, Eric Blake wrote: >> Noticed while reviewing another patch that had an accidental >> mismatch due to refactoring. An audit of the code showed that >> very few callers of vshCommandOpt were expecting a return of >> -2, indicatin

Re: [libvirt] [PATCH] virsh: detect programming errors with option parsing

2013-08-28 Thread Michal Privoznik
On 17.08.2013 00:14, Eric Blake wrote: > Noticed while reviewing another patch that had an accidental > mismatch due to refactoring. An audit of the code showed that > very few callers of vshCommandOpt were expecting a return of > -2, indicating programmer error, and of those that DID check, > the

[libvirt] [PATCH] virsh: detect programming errors with option parsing

2013-08-16 Thread Eric Blake
Noticed while reviewing another patch that had an accidental mismatch due to refactoring. An audit of the code showed that very few callers of vshCommandOpt were expecting a return of -2, indicating programmer error, and of those that DID check, they just propagated that status to yet another call