[PATCH] virsh edit (v3) (was: Re: [libvirt] [PATCH] virsh edit, virsh net-edit, virsh pool-edit)

2008-08-01 Thread Richard W.M. Jones
Thanks for reviewing this patch. On Fri, Aug 01, 2008 at 10:02:50AM +0200, Jim Meyering wrote: > What if either contains shell meta-characters? > To accommodate you'd have to shell-quote as needed, or (as I prefer) > simply detect the bogosity and refuse to run the command. Yes, not quite sure wh

Re: [libvirt] [PATCH] virsh edit, virsh net-edit, virsh pool-edit

2008-08-01 Thread Richard W.M. Jones
On Fri, Aug 01, 2008 at 10:02:50AM +0200, Jim Meyering wrote: > "Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > > +static int > > +cmdEdit (vshControl *ctl, vshCmd *cmd) > > +{ > ... > > +static int > > +cmdNetworkEdit (vshControl *ctl, vshCmd *cmd) > > +{ > ... > > +static int > > +cmdPoolEdit (

Re: [libvirt] [PATCH] virsh edit, virsh net-edit, virsh pool-edit

2008-08-01 Thread Jim Meyering
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > This implements 'virsh edit', 'virsh net-edit' and 'virsh pool-edit' > commands. Hi Rich, > Index: src/virsh.c > === > RCS file: /data/cvs/libvirt/src/virsh.c,v > retrieving revision

[libvirt] [PATCH] virsh edit, virsh net-edit, virsh pool-edit

2008-07-30 Thread Richard W.M. Jones
This implements 'virsh edit', 'virsh net-edit' and 'virsh pool-edit' commands. Previous discussion of this patch was in this thread: https://www.redhat.com/archives/libvir-list/2008-July/thread.html#00434 Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt