Re: [libvirt] [PATCH] xen: Don't crash when we fail to init caps

2012-01-23 Thread Guido Günther
On Mon, Jan 23, 2012 at 10:22:35AM +, Daniel P. Berrange wrote: > On Sun, Jan 22, 2012 at 12:30:20PM +0100, Guido Günther wrote: > > On Fri, Jan 20, 2012 at 05:01:48PM +, Daniel P. Berrange wrote: > > > On Fri, Jan 20, 2012 at 05:57:34PM +0100, Guido Günther wrote: > > > > by dereferencing

Re: [libvirt] [PATCH] xen: Don't crash when we fail to init caps

2012-01-23 Thread Daniel P. Berrange
On Sun, Jan 22, 2012 at 12:30:20PM +0100, Guido Günther wrote: > On Fri, Jan 20, 2012 at 05:01:48PM +, Daniel P. Berrange wrote: > > On Fri, Jan 20, 2012 at 05:57:34PM +0100, Guido Günther wrote: > > > by dereferencing a NULL pointer in the call to > > > virNodeSuspendGetTargetMask. > > > > >

Re: [libvirt] [PATCH] xen: Don't crash when we fail to init caps

2012-01-22 Thread Guido Günther
On Fri, Jan 20, 2012 at 05:01:48PM +, Daniel P. Berrange wrote: > On Fri, Jan 20, 2012 at 05:57:34PM +0100, Guido Günther wrote: > > by dereferencing a NULL pointer in the call to > > virNodeSuspendGetTargetMask. > > > > Only warn but Don't set an error to not overwrite an error code set by >

Re: [libvirt] [PATCH] xen: Don't crash when we fail to init caps

2012-01-20 Thread Guido Günther
On Fri, Jan 20, 2012 at 05:01:48PM +, Daniel P. Berrange wrote: > On Fri, Jan 20, 2012 at 05:57:34PM +0100, Guido Günther wrote: > > by dereferencing a NULL pointer in the call to > > virNodeSuspendGetTargetMask. > > > > Only warn but Don't set an error to not overwrite an error code set by >

[libvirt] [PATCH] xen: Don't crash when we fail to init caps

2012-01-20 Thread Guido Günther
by dereferencing a NULL pointer in the call to virNodeSuspendGetTargetMask. Only warn but Don't set an error to not overwrite an error code set by xenHypervisorMakeCapabilities. --- src/xen/xen_hypervisor.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/xen/xen_hy

Re: [libvirt] [PATCH] xen: Don't crash when we fail to init caps

2012-01-20 Thread Daniel P. Berrange
On Fri, Jan 20, 2012 at 05:57:34PM +0100, Guido Günther wrote: > by dereferencing a NULL pointer in the call to > virNodeSuspendGetTargetMask. > > Only warn but Don't set an error to not overwrite an error code set by > xenHypervisorMakeCapabilities. > --- > src/xen/xen_hypervisor.c |4 >