Re: [libvirt] [PATCH-v4 2/2] Support for static routes on a virtual bridge

2013-04-26 Thread Gene Czarcinski
On 04/26/2013 09:16 AM, Gene Czarcinski wrote: On 04/25/2013 04:37 PM, Laine Stump wrote: On 04/25/2013 04:13 PM, Gene Czarcinski wrote: On 04/25/2013 03:13 PM, Gene Czarcinski wrote: On 04/22/2013 11:59 AM, Laine Stump wrote: address should be optional unless prefix or netmask is non-0, alth

Re: [libvirt] [PATCH-v4 2/2] Support for static routes on a virtual bridge

2013-04-26 Thread Gene Czarcinski
On 04/25/2013 04:37 PM, Laine Stump wrote: On 04/25/2013 04:13 PM, Gene Czarcinski wrote: On 04/25/2013 03:13 PM, Gene Czarcinski wrote: On 04/22/2013 11:59 AM, Laine Stump wrote: address should be optional unless prefix or netmask is non-0, although I've now noticed that won't be handled prop

Re: [libvirt] [PATCH-v4 2/2] Support for static routes on a virtual bridge

2013-04-25 Thread Laine Stump
On 04/25/2013 04:13 PM, Gene Czarcinski wrote: > On 04/25/2013 03:13 PM, Gene Czarcinski wrote: >> On 04/22/2013 11:59 AM, Laine Stump wrote: >>> address should be optional unless prefix or netmask is non-0, although >>> I've now noticed that won't be handled properly due to >>> virSocketAddrGetIpP

Re: [libvirt] [PATCH-v4 2/2] Support for static routes on a virtual bridge

2013-04-25 Thread Eric Blake
On 04/25/2013 02:13 PM, Gene Czarcinski wrote: >> It is getting real close and it should be ready "real soon now" ;)) >> > AAGH > > With IPv4 using address='0.0.0.0' and netmask='0.0.0.0' things work just > fine but with prefix not so much. The problem is that with prefix=0, it > is not i

Re: [libvirt] [PATCH-v4 2/2] Support for static routes on a virtual bridge

2013-04-25 Thread Gene Czarcinski
On 04/25/2013 03:13 PM, Gene Czarcinski wrote: On 04/22/2013 11:59 AM, Laine Stump wrote: address should be optional unless prefix or netmask is non-0, although I've now noticed that won't be handled properly due to virSocketAddrGetIpPrefix returning -1 when there is no address or prefix or netm

Re: [libvirt] [PATCH-v4 2/2] Support for static routes on a virtual bridge

2013-04-25 Thread Gene Czarcinski
On 04/22/2013 11:59 AM, Laine Stump wrote: address should be optional unless prefix or netmask is non-0, although I've now noticed that won't be handled properly due to virSocketAddrGetIpPrefix returning -1 when there is no address or prefix or netmask (I'm fixing that before I push that patch, s

Re: [libvirt] [PATCH-v4 2/2] Support for static routes on a virtual bridge

2013-04-22 Thread Laine Stump
(I had thought there would be just a few tweaks to the documentation that I could squash in and push, but as I reviewed I found more issues, and don't have time to fix them myself. It is *very* close though, and the freeze for 1.0.5 is coming up (within a couple days, I think?), so if you can make

[libvirt] [PATCH-v4 2/2] Support for static routes on a virtual bridge

2013-04-20 Thread Gene Czarcinski
This patch adds support for adding a static route for a network. The "gateway" sub-element specifies the gateway's IP address. Both IPv4 and IPv6 static routes are supported although it is expected that this functionality will have more use with IPv6. This updates add the element to define a st