Re: [libvirt] [PATCH 01/10] Replace sscanf in legacy device address parsing

2010-03-30 Thread Matthias Bolte
2010/3/30 Eric Blake : > On 03/30/2010 10:20 AM, Matthias Bolte wrote: >> +static int >> +virDomainParseLegacyDeviceAddress(char *devaddr, >> +                                  virDomainDevicePCIAddressPtr pci) >> +{ >> +    char *tmp = devaddr + strspn(devaddr, " \t\r\n"); > > Why skip leading whi

Re: [libvirt] [PATCH 01/10] Replace sscanf in legacy device address parsing

2010-03-30 Thread Eric Blake
On 03/30/2010 10:20 AM, Matthias Bolte wrote: > +static int > +virDomainParseLegacyDeviceAddress(char *devaddr, > + virDomainDevicePCIAddressPtr pci) > +{ > +char *tmp = devaddr + strspn(devaddr, " \t\r\n"); Why skip leading whitespace yourself... > + > +/

[libvirt] [PATCH 01/10] Replace sscanf in legacy device address parsing

2010-03-30 Thread Matthias Bolte
--- src/conf/domain_conf.c | 38 ++ 1 files changed, 26 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 66aa53e..9a517ca 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1290,6 +1290,26 @@