Re: [libvirt] [PATCH 01/11] Add public API definition for data stream handling

2009-09-25 Thread Daniel Veillard
On Fri, Sep 25, 2009 at 02:09:54PM +0100, Daniel P. Berrange wrote: > On Fri, Sep 25, 2009 at 02:32:39PM +0200, Daniel Veillard wrote: > > Hum, this would then raise the signal that stream can be used > > both ways, do we really want to suggest this at the API level, > > I can see how we're gonna

Re: [libvirt] [PATCH 01/11] Add public API definition for data stream handling

2009-09-25 Thread Daniel P. Berrange
On Fri, Sep 25, 2009 at 02:32:39PM +0200, Daniel Veillard wrote: > On Fri, Sep 25, 2009 at 12:25:50PM +0100, Daniel P. Berrange wrote: > > > if we needed more than just plain flags. > > > > > > On the subject of flags though, I've never been entirely sure > > about whether it would be worth mand

Re: [libvirt] [PATCH 01/11] Add public API definition for data stream handling

2009-09-25 Thread Daniel Veillard
On Fri, Sep 25, 2009 at 12:25:50PM +0100, Daniel P. Berrange wrote: > On Fri, Sep 25, 2009 at 12:09:34PM +0200, Daniel Veillard wrote: > > On Mon, Aug 24, 2009 at 09:51:04PM +0100, Daniel P. Berrange wrote: > > > @@ -1448,6 +1466,81 @@ void virEventRegisterImpl(virEventAddHandleFunc > > > addHandl

Re: [libvirt] [PATCH 01/11] Add public API definition for data stream handling

2009-09-25 Thread Daniel P. Berrange
On Fri, Sep 25, 2009 at 12:09:34PM +0200, Daniel Veillard wrote: > On Mon, Aug 24, 2009 at 09:51:04PM +0100, Daniel P. Berrange wrote: > > @@ -1448,6 +1466,81 @@ void virEventRegisterImpl(virEventAddHandleFunc > > addHandle, > >virEventAddTimeoutFunc addTimeout, > >

Re: [libvirt] [PATCH 01/11] Add public API definition for data stream handling

2009-09-25 Thread Daniel Veillard
On Mon, Aug 24, 2009 at 09:51:04PM +0100, Daniel P. Berrange wrote: > * include/libvirt/libvirt.h, include/libvirt/libvirt.h.in: Public > API contract for virStreamPtr object > * src/libvirt_public.syms: Export data stream APIs > * src/libvirt_private.syms: Export internal helper APIs > * src/lib

[libvirt] [PATCH 01/11] Add public API definition for data stream handling

2009-08-24 Thread Daniel P. Berrange
* include/libvirt/libvirt.h, include/libvirt/libvirt.h.in: Public API contract for virStreamPtr object * src/libvirt_public.syms: Export data stream APIs * src/libvirt_private.syms: Export internal helper APIs * src/libvirt.c: Data stream API driver dispatch * src/datatypes.h, src/datatypes.c: In