Re: [libvirt] [PATCH 01/11] Fix parsing of port attribute in storage XML configuration

2010-11-19 Thread Eric Blake
On 11/12/2010 11:36 AM, Daniel P. Berrange wrote: > On Fri, Nov 12, 2010 at 10:21:16AM -0700, Eric Blake wrote: >> On 11/12/2010 09:22 AM, Daniel P. Berrange wrote: >>> The XML docs describe a 'port' attribute for the >>> storage source element, but the parser never >>> handled it. >>> >>> * docs/

Re: [libvirt] [PATCH 01/11] Fix parsing of port attribute in storage XML configuration

2010-11-12 Thread Daniel P. Berrange
On Fri, Nov 12, 2010 at 10:21:16AM -0700, Eric Blake wrote: > On 11/12/2010 09:22 AM, Daniel P. Berrange wrote: > > The XML docs describe a 'port' attribute for the > > storage source element, but the parser never > > handled it. > > > > * docs/schemas/storagepool.rng: Define port attribute > > *

Re: [libvirt] [PATCH 01/11] Fix parsing of port attribute in storage XML configuration

2010-11-12 Thread Eric Blake
On 11/12/2010 09:22 AM, Daniel P. Berrange wrote: > The XML docs describe a 'port' attribute for the > storage source element, but the parser never > handled it. > > * docs/schemas/storagepool.rng: Define port attribute > * src/conf/storage_conf.c: Add missing parsing/formatting > of host port

[libvirt] [PATCH 01/11] Fix parsing of port attribute in storage XML configuration

2010-11-12 Thread Daniel P. Berrange
The XML docs describe a 'port' attribute for the storage source element, but the parser never handled it. * docs/schemas/storagepool.rng: Define port attribute * src/conf/storage_conf.c: Add missing parsing/formatting of host port number * src/conf/storage_conf.h: Remove bogus/unused 'protocol'