- Original Message -
> From: "Francesco Romani"
> To: libvir-list@redhat.com
> Sent: Wednesday, September 3, 2014 8:41:13 AM
> Subject: Re: [libvirt] [PATCH 01/11] qemu: extract helper to get the current
> balloon
[...]
> > > +
On 09/02/2014 03:01 PM, Eric Blake wrote:
>> +if (!virDomainObjIsActive(vm))
>> +err = 0;
>> +else {
>
> [2] If one leg of if-else has {}, both legs must have it. This is
> documented in HACKING (and I really ought to add a syntax check that
> forbids obvious cases of
On 09/03/2014 12:41 AM, Francesco Romani wrote:
>>
>> [3] Ouch. This function is unlocking vm, even though it did not obtain
>> the lock. Which it kind of has to do because of the way that
>> qemuDomainObjEndJob may end up invalidating vm. While transfer
>> semantics are workable, they require
- Original Message -
> From: "Eric Blake"
> To: "Francesco Romani" , libvir-list@redhat.com
> Sent: Tuesday, September 2, 2014 11:01:25 PM
> Subject: Re: [libvirt] [PATCH 01/11] qemu: extract helper to get the current
> balloon
Hi Eric, thanks for th
On 09/02/2014 06:31 AM, Francesco Romani wrote:
> Refactor the code to extract an helper method
> to get the current balloon settings.
>
> Signed-off-by: Francesco Romani
> ---
> src/qemu/qemu_driver.c | 98
> ++
> 1 file changed, 60 insertions(+)
Refactor the code to extract an helper method
to get the current balloon settings.
Signed-off-by: Francesco Romani
---
src/qemu/qemu_driver.c | 98 ++
1 file changed, 60 insertions(+), 38 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu
Refactor the code to extract an helper method
to get the current balloon settings.
Signed-off-by: Francesco Romani
---
src/qemu/qemu_driver.c | 98 ++
1 file changed, 60 insertions(+), 38 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu
