I agree. This must have slipped in during the countless iterations.
Thanks for catching it.
Reviewed-by: Boris Fiuczynski
On 3/21/19 11:28 PM, Laine Stump wrote:
qemuDomainDetachControllerDevice() calls
qemuDomainDetachExtensionDevice() when the *controller* type is
PCI. This is incorrect in m
On Thu, Mar 21, 2019 at 06:28:41PM -0400, Laine Stump wrote:
qemuDomainDetachControllerDevice() calls
qemuDomainDetachExtensionDevice() when the *controller* type is
PCI. This is incorrect in multiple ways:
* Any code that tears down a device should be in the
qemuDomainRemove*Device() function
On Thu, Mar 21, 2019 at 18:28:41 -0400, Laine Stump wrote:
> qemuDomainDetachControllerDevice() calls
> qemuDomainDetachExtensionDevice() when the *controller* type is
> PCI. This is incorrect in multiple ways:
>
> * Any code that tears down a device should be in the
> qemuDomainRemove*Device()
qemuDomainDetachControllerDevice() calls
qemuDomainDetachExtensionDevice() when the *controller* type is
PCI. This is incorrect in multiple ways:
* Any code that tears down a device should be in the
qemuDomainRemove*Device() function (which is called after libvirt
gets a DEVICE_DELETED event f
