Re: [libvirt] [PATCH 02/11] Refactor iSCSI driver code to facilitate future changes

2010-11-12 Thread Dave Allan
On Fri, Nov 12, 2010 at 06:37:36PM +, Daniel P. Berrange wrote: > On Fri, Nov 12, 2010 at 12:39:57PM -0500, Dave Allan wrote: > > On Fri, Nov 12, 2010 at 04:22:35PM +, Daniel P. Berrange wrote: > > > The following series of patches are adding significant > > > extra functionality to the iSC

Re: [libvirt] [PATCH 02/11] Refactor iSCSI driver code to facilitate future changes

2010-11-12 Thread Daniel P. Berrange
On Fri, Nov 12, 2010 at 12:39:57PM -0500, Dave Allan wrote: > On Fri, Nov 12, 2010 at 04:22:35PM +, Daniel P. Berrange wrote: > > The following series of patches are adding significant > > extra functionality to the iSCSI driver. THe current > > internal helper methods are not sufficiently flex

Re: [libvirt] [PATCH 02/11] Refactor iSCSI driver code to facilitate future changes

2010-11-12 Thread Dave Allan
On Fri, Nov 12, 2010 at 04:22:35PM +, Daniel P. Berrange wrote: > The following series of patches are adding significant > extra functionality to the iSCSI driver. THe current > internal helper methods are not sufficiently flexible > to cope with these changes. This patch refactors the > code t

[libvirt] [PATCH 02/11] Refactor iSCSI driver code to facilitate future changes

2010-11-12 Thread Daniel P. Berrange
The following series of patches are adding significant extra functionality to the iSCSI driver. THe current internal helper methods are not sufficiently flexible to cope with these changes. This patch refactors the code to avoid needing to have a virStoragePoolObjPtr instance as a parameter, instea