Re: [libvirt] [PATCH 02/12] qemu: command: Format frontend props with -device rather than -drive

2017-11-21 Thread Peter Krempa
On Mon, Nov 20, 2017 at 18:25:19 +0100, Peter Krempa wrote: > Historically we've formatted a lot of the attributes of a disk (disk > geometry, etc) with -drive. Since we use -device now, they should be > formatted there. > --- > src/qemu/qemu_command.c| 5 - > t

[libvirt] [PATCH 02/12] qemu: command: Format frontend props with -device rather than -drive

2017-11-20 Thread Peter Krempa
Historically we've formatted a lot of the attributes of a disk (disk geometry, etc) with -drive. Since we use -device now, they should be formatted there. --- src/qemu/qemu_command.c| 5 - tests/qemuxml2argvdata/qemuxml2argv-disk-geometry.args | 6 +++--- 2 file