Re: [libvirt] [PATCH 02/12] qemu: rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr and change something

2015-01-06 Thread lhuang
On 01/07/2015 01:16 AM, Eric Blake wrote: On 01/05/2015 11:56 PM, lhuang wrote: On 01/05/2015 11:18 PM, Peter Krempa wrote: Subject: "change something"? That's a really vague statement. How about: qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in RNG hotplug Good subject :) Thanks On

Re: [libvirt] [PATCH 02/12] qemu: rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr and change something

2015-01-06 Thread Eric Blake
On 01/05/2015 11:56 PM, lhuang wrote: > > On 01/05/2015 11:18 PM, Peter Krempa wrote: >> Subject: "change something"? That's a really vague statement. >> >> How about: >> >> qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in RNG hotplug > Good subject :) > Thanks >> On 01/03/15 06:06, Luyao H

Re: [libvirt] [PATCH 02/12] qemu: rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr and change something

2015-01-05 Thread lhuang
On 01/05/2015 11:18 PM, Peter Krempa wrote: Subject: "change something"? That's a really vague statement. How about: qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in RNG hotplug Good subject :) Thanks On 01/03/15 06:06, Luyao Huang wrote: rename qemuBuildRNGDeviceArgs to qemuBuildRNG

Re: [libvirt] [PATCH 02/12] qemu: rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr and change something

2015-01-05 Thread Peter Krempa
Subject: "change something"? That's a really vague statement. How about: qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in RNG hotplug On 01/03/15 06:06, Luyao Huang wrote: > rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr, we need this function > to build a cmdline. Rename qemuBuildR

[libvirt] [PATCH 02/12] qemu: rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr and change something

2015-01-02 Thread Luyao Huang
rename qemuBuildRNGDeviceArgs to qemuBuildRNGDevStr, we need this function to build a cmdline. Signed-off-by: Luyao Huang --- src/qemu/qemu_command.c | 33 - src/qemu/qemu_command.h | 4 2 files changed, 20 insertions(+), 17 deletions(-) diff --git a/src/qe