Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-15 Thread Eric Blake
On 03/15/2013 10:17 AM, Daniel P. Berrange wrote: >> Ok to push 3-10 and 14 too? Then I'll send the coding style adjustments >> that Osier requested (but Dan acked nevertheless) and 11-13 which need a >> bit more work. > > Nope, not ok to push 7 or 8, given the way it represents IQN & LUN as > se

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-15 Thread Daniel P. Berrange
On Fri, Mar 15, 2013 at 04:56:26PM +0100, Paolo Bonzini wrote: > Il 15/03/2013 15:43, Eric Blake ha scritto: > > On 03/15/2013 08:29 AM, Daniel P. Berrange wrote: > >> On Mon, Feb 25, 2013 at 06:44:21PM +0100, Paolo Bonzini wrote: > >>> QEMU added -drive in 2007, and NBD in 2008. Both appeared fir

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-15 Thread Paolo Bonzini
Il 15/03/2013 15:43, Eric Blake ha scritto: > On 03/15/2013 08:29 AM, Daniel P. Berrange wrote: >> On Mon, Feb 25, 2013 at 06:44:21PM +0100, Paolo Bonzini wrote: >>> QEMU added -drive in 2007, and NBD in 2008. Both appeared first in >>> release 0.10.0. Thus the code to support network disks witho

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-15 Thread Eric Blake
On 03/15/2013 08:29 AM, Daniel P. Berrange wrote: > On Mon, Feb 25, 2013 at 06:44:21PM +0100, Paolo Bonzini wrote: >> QEMU added -drive in 2007, and NBD in 2008. Both appeared first in >> release 0.10.0. Thus the code to support network disks without -drive >> is dead, and in fact it incorrectly

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-15 Thread Daniel P. Berrange
On Mon, Feb 25, 2013 at 06:44:21PM +0100, Paolo Bonzini wrote: > QEMU added -drive in 2007, and NBD in 2008. Both appeared first in > release 0.10.0. Thus the code to support network disks without -drive > is dead, and in fact it incorrectly escapes commas. Drop it. > > Signed-off-by: Paolo Bon

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-11 Thread Osier Yang
On 2013年03月11日 21:16, Paolo Bonzini wrote: Il 11/03/2013 04:23, Osier Yang ha scritto: On 2013年02月26日 01:44, Paolo Bonzini wrote: QEMU added -drive in 2007, and NBD in 2008. Both appeared first in release 0.10.0. Thus the code to support network disks without -drive is dead, and in fact it in

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 04:23, Osier Yang ha scritto: > On 2013年02月26日 01:44, Paolo Bonzini wrote: >> QEMU added -drive in 2007, and NBD in 2008. Both appeared first in >> release 0.10.0. Thus the code to support network disks without -drive >> is dead, and in fact it incorrectly escapes commas. Drop it.

Re: [libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-03-10 Thread Osier Yang
On 2013年02月26日 01:44, Paolo Bonzini wrote: QEMU added -drive in 2007, and NBD in 2008. Both appeared first in release 0.10.0. Thus the code to support network disks without -drive is dead, and in fact it incorrectly escapes commas. Drop it. The network disks support appeared in 0.8.7: Jan 4

[libvirt] [PATCH 02/13] qemu: do not support non-network disks without -drive

2013-02-25 Thread Paolo Bonzini
QEMU added -drive in 2007, and NBD in 2008. Both appeared first in release 0.10.0. Thus the code to support network disks without -drive is dead, and in fact it incorrectly escapes commas. Drop it. Signed-off-by: Paolo Bonzini --- src/qemu/qemu_command.c | 53 ++---