Re: [libvirt] [PATCH 02/29] Add a test suite for validating SELinux labelling

2012-09-21 Thread Eric Blake
On 09/21/2012 07:21 AM, Daniel P. Berrange wrote: >>> +while (!feof(fp)) { >>> +char *line; >>> +char *file, *context; >>> +if (VIR_ALLOC_N(line, 1024) < 0) { >>> +virReportOOMError(); >>> +goto cleanup; >>> +} >>> +if (!fgets(line

Re: [libvirt] [PATCH 02/29] Add a test suite for validating SELinux labelling

2012-09-21 Thread Daniel P. Berrange
On Thu, Sep 20, 2012 at 04:06:29PM -0600, Eric Blake wrote: > On 09/20/2012 09:01 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > There are many aspects of the guest XML which result in the > > SELinux driver applying file labelling. With the increasing > > configuration opti

Re: [libvirt] [PATCH 02/29] Add a test suite for validating SELinux labelling

2012-09-20 Thread Eric Blake
On 09/20/2012 09:01 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > There are many aspects of the guest XML which result in the > SELinux driver applying file labelling. With the increasing > configuration options it is desirable to test this behaviour. > It is not possible to assu

[libvirt] [PATCH 02/29] Add a test suite for validating SELinux labelling

2012-09-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" There are many aspects of the guest XML which result in the SELinux driver applying file labelling. With the increasing configuration options it is desirable to test this behaviour. It is not possible to assume that the test suite has the ability to set SELinux labels.