Re: [libvirt] [PATCH 03/10] cleanup: Don't include libvirt/libvirt.h

2013-04-17 Thread Osier Yang
On 17/04/13 23:07, Eric Blake wrote: On 04/17/2013 06:38 AM, Osier Yang wrote: */ -%#include %#include "internal.h" %#include This has broken make check Let's revert this hunk, and stop enforcing the checks on .x files, then. GEN remote_protocol-struct --- remote_

Re: [libvirt] [PATCH 03/10] cleanup: Don't include libvirt/libvirt.h

2013-04-17 Thread Eric Blake
On 04/17/2013 06:38 AM, Osier Yang wrote: >>>*/ >>> -%#include >>> %#include "internal.h" >>> %#include >>> >> This has broken make check Let's revert this hunk, and stop enforcing the checks on .x files, then. >> >>GEN remote_protocol-struct >> --- remote_protocol-structs

Re: [libvirt] [PATCH 03/10] cleanup: Don't include libvirt/libvirt.h

2013-04-17 Thread Osier Yang
On 17/04/13 18:58, Daniel P. Berrange wrote: On Tue, Apr 16, 2013 at 09:41:45PM +0800, Osier Yang wrote: Which is already included by "internal.h", later patch will add syntax-check to avoid it. --- src/nodeinfo.h | 1 - src/phyp/phyp_driver.c | 1 - src/remote/remote_pro

Re: [libvirt] [PATCH 03/10] cleanup: Don't include libvirt/libvirt.h

2013-04-17 Thread Daniel P. Berrange
On Tue, Apr 16, 2013 at 09:41:45PM +0800, Osier Yang wrote: > Which is already included by "internal.h", later patch will add > syntax-check to avoid it. > --- > src/nodeinfo.h | 1 - > src/phyp/phyp_driver.c | 1 - > src/remote/remote_protocol.x | 1 - > src/util/virkeycode.h

Re: [libvirt] [PATCH 03/10] cleanup: Don't include libvirt/libvirt.h

2013-04-16 Thread Eric Blake
On 04/16/2013 07:41 AM, Osier Yang wrote: > Which is already included by "internal.h", later patch will add > syntax-check to avoid it. > --- > +++ b/src/nodeinfo.h > @@ -24,7 +24,6 @@ > #ifndef __VIR_NODEINFO_H__ > # define __VIR_NODEINFO_H__ > > -# include "libvirt/libvirt.h" > # include "c

Re: [libvirt] [PATCH 03/10] cleanup: Don't include libvirt/libvirt.h

2013-04-16 Thread Eric Blake
On 04/16/2013 07:41 AM, Osier Yang wrote: > Which is already included by "internal.h", later patch will add > syntax-check to avoid it. > --- ACK -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital s

[libvirt] [PATCH 03/10] cleanup: Don't include libvirt/libvirt.h

2013-04-16 Thread Osier Yang
Which is already included by "internal.h", later patch will add syntax-check to avoid it. --- src/nodeinfo.h | 1 - src/phyp/phyp_driver.c | 1 - src/remote/remote_protocol.x | 1 - src/util/virkeycode.h| 1 - 4 files changed, 4 deletions(-) diff --git a/src/nodeinfo.h