Re: [libvirt] [PATCH 03/14] qemu: Introduce qemuDomainChrDefPostParse()

2017-11-16 Thread Andrea Bolognani
On Thu, 2017-11-16 at 11:30 +0100, Pavel Hrdina wrote: > > @@ -4096,13 +4109,6 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr > > dev, > > } > > } > > > > -/* set the default console type for S390 arches */ > > -if (dev->type == VIR_DOMAIN_DEVICE_CHR && > > -

Re: [libvirt] [PATCH 03/14] qemu: Introduce qemuDomainChrDefPostParse()

2017-11-16 Thread Pavel Hrdina
On Wed, Nov 15, 2017 at 12:50:06PM +0100, Andrea Bolognani wrote: > Having a separate function for char device handling is better than > adding even more code to qemuDomainDeviceDefPostParse(). > > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_domain.c | 25 ++--- > 1

[libvirt] [PATCH 03/14] qemu: Introduce qemuDomainChrDefPostParse()

2017-11-15 Thread Andrea Bolognani
Having a separate function for char device handling is better than adding even more code to qemuDomainDeviceDefPostParse(). Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_doma