Re: [libvirt] [PATCH 03/16] snapshot: Create virDomainMoment base class

2019-03-21 Thread Eric Blake
On 3/20/19 2:57 PM, John Ferlan wrote: > > > On 3/20/19 1:40 AM, Eric Blake wrote: >> Upcoming patches want to add virDomainCheckpoint that behaves very >> similarly to virDomainSnapshot; the easiest way to share common code >> is to give both classes a common base class. Thanks to the accessor

Re: [libvirt] [PATCH 03/16] snapshot: Create virDomainMoment base class

2019-03-20 Thread John Ferlan
On 3/20/19 1:40 AM, Eric Blake wrote: > Upcoming patches want to add virDomainCheckpoint that behaves very > similarly to virDomainSnapshot; the easiest way to share common code > is to give both classes a common base class. Thanks to the accessor > functions in the previous patch, we have very

[libvirt] [PATCH 03/16] snapshot: Create virDomainMoment base class

2019-03-19 Thread Eric Blake
Upcoming patches want to add virDomainCheckpoint that behaves very similarly to virDomainSnapshot; the easiest way to share common code is to give both classes a common base class. Thanks to the accessor functions in the previous patch, we have very few changes required outside of datatypes.[ch].