Re: [libvirt] [PATCH 03/18] Introduce a virFileDeleteTree method

2013-04-08 Thread Eric Blake
On 04/08/2013 08:04 AM, Daniel P. Berrange wrote: >> We should use gnulib's LGPL unlinkat. On capable kernels, it avoids >> O(n^2) behavior that is inherent in computing filenames in a deep >> hierarchy. On less capable kernels, it still makes this code simpler to >> write (no virAsprintf needed

Re: [libvirt] [PATCH 03/18] Introduce a virFileDeleteTree method

2013-04-08 Thread Daniel P. Berrange
On Thu, Apr 04, 2013 at 11:56:29AM -0600, Eric Blake wrote: > On 04/04/2013 07:40 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Introduce a method virFileDeleteTree for recursively deleting > > an entire directory tree > > > > Signed-off-by: Daniel P. Berrange > > --- > >

Re: [libvirt] [PATCH 03/18] Introduce a virFileDeleteTree method

2013-04-04 Thread Daniel P. Berrange
On Thu, Apr 04, 2013 at 11:56:29AM -0600, Eric Blake wrote: > On 04/04/2013 07:40 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Introduce a method virFileDeleteTree for recursively deleting > > an entire directory tree > > > > Signed-off-by: Daniel P. Berrange > > --- > >

Re: [libvirt] [PATCH 03/18] Introduce a virFileDeleteTree method

2013-04-04 Thread Eric Blake
On 04/04/2013 07:40 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Introduce a method virFileDeleteTree for recursively deleting > an entire directory tree > > Signed-off-by: Daniel P. Berrange > --- > src/libvirt_private.syms | 1 + > src/util/virfile.c | 78 >

[libvirt] [PATCH 03/18] Introduce a virFileDeleteTree method

2013-04-04 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Introduce a method virFileDeleteTree for recursively deleting an entire directory tree Signed-off-by: Daniel P. Berrange --- src/libvirt_private.syms | 1 + src/util/virfile.c | 78 src/util/virfile.h | 2