Re: [libvirt] [PATCH 05/10] util: resctrl: refactoring some functions

2018-09-10 Thread Wang, Huaqiang
> -Original Message- > From: John Ferlan [mailto:jfer...@redhat.com] > Sent: Saturday, September 8, 2018 1:41 AM > To: Wang, Huaqiang ; libvir-list@redhat.com > Cc: Feng, Shaohe ; Niu, Bing ; > Ding, Jian-feng ; Zang, Rui > Subject: Re: [libvirt] [PATCH

Re: [libvirt] [PATCH 05/10] util: resctrl: refactoring some functions

2018-09-07 Thread John Ferlan
On 09/07/2018 06:52 AM, Wang, Huaqiang wrote: > > [...] >>> +static int >>> +virResctrlCreateGroup(virResctrlInfoPtr resctrl, >>> + char *path) >> >> s/char/const char/ >> > > Will be fixed. > >> should be: >> >> virResctrlCreateGroupPath >> > > I prefer the origi

Re: [libvirt] [PATCH 05/10] util: resctrl: refactoring some functions

2018-09-07 Thread Wang, Huaqiang
> -Original Message- > From: John Ferlan [mailto:jfer...@redhat.com] > Sent: Wednesday, September 5, 2018 10:49 PM > To: Wang, Huaqiang ; libvir-list@redhat.com > Cc: Feng, Shaohe ; Niu, Bing ; > Ding, Jian-feng ; Zang, Rui > Subject: Re: [libvirt] [PATCH

Re: [libvirt] [PATCH 05/10] util: resctrl: refactoring some functions

2018-09-05 Thread John Ferlan
On 08/27/2018 07:23 AM, Wang Huaqiang wrote: > Some code, in virresctrl.c, manupulating the file objects of resctrlfs > could be reused for cache monitor interfaces. This patch refactor these > functions for purpose of reusing code in later patch: > > virResctrlAllocDeterminePath > virResctrlAl

[libvirt] [PATCH 05/10] util: resctrl: refactoring some functions

2018-08-27 Thread Wang Huaqiang
Some code, in virresctrl.c, manupulating the file objects of resctrlfs could be reused for cache monitor interfaces. This patch refactor these functions for purpose of reusing code in later patch: virResctrlAllocDeterminePath virResctrlAllocCreate virResctrlAddPID Signed-off-by: Wang Huaqiang --