Re: [libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

2019-12-19 Thread Pavel Hrdina
On Thu, Dec 19, 2019 at 05:42:14PM +0100, Ján Tomko wrote: > On Thu, Dec 19, 2019 at 05:25:59PM +0100, Pavel Hrdina wrote: > > On Thu, Dec 19, 2019 at 05:21:21PM +0100, Fabiano Fidêncio wrote: > > > On Thu, Dec 19, 2019 at 5:07 PM Pavel Hrdina wrote: > > > > > > > > On Thu, Dec 19, 2019 at 11:04:1

Re: [libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

2019-12-19 Thread Ján Tomko
On Thu, Dec 19, 2019 at 05:25:59PM +0100, Pavel Hrdina wrote: On Thu, Dec 19, 2019 at 05:21:21PM +0100, Fabiano Fidêncio wrote: On Thu, Dec 19, 2019 at 5:07 PM Pavel Hrdina wrote: > > On Thu, Dec 19, 2019 at 11:04:10AM +0100, Fabiano Fidêncio wrote: > > virGetUserDirectory() *never* *ever* retu

Re: [libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

2019-12-19 Thread Ján Tomko
On Thu, Dec 19, 2019 at 11:04:10AM +0100, Fabiano Fidêncio wrote: virGetUserDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetclient.c | 12 src/rpc/virnettlscontext.c | 12 2 f

Re: [libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

2019-12-19 Thread Pavel Hrdina
On Thu, Dec 19, 2019 at 05:21:21PM +0100, Fabiano Fidêncio wrote: > On Thu, Dec 19, 2019 at 5:07 PM Pavel Hrdina wrote: > > > > On Thu, Dec 19, 2019 at 11:04:10AM +0100, Fabiano Fidêncio wrote: > > > virGetUserDirectory() *never* *ever* returns NULL, making the checks for > > > it completely unnec

Re: [libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

2019-12-19 Thread Fabiano Fidêncio
On Thu, Dec 19, 2019 at 5:07 PM Pavel Hrdina wrote: > > On Thu, Dec 19, 2019 at 11:04:10AM +0100, Fabiano Fidêncio wrote: > > virGetUserDirectory() *never* *ever* returns NULL, making the checks for > > it completely unnecessary. > > > > Signed-off-by: Fabiano Fidêncio > > --- > > src/rpc/virnet

Re: [libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

2019-12-19 Thread Pavel Hrdina
On Thu, Dec 19, 2019 at 11:04:10AM +0100, Fabiano Fidêncio wrote: > virGetUserDirectory() *never* *ever* returns NULL, making the checks for > it completely unnecessary. > > Signed-off-by: Fabiano Fidêncio > --- > src/rpc/virnetclient.c | 12 > src/rpc/virnettlscontext.c | 12 --

[libvirt] [PATCH 05/42] rpc: Don't check the output of virGetUserDirectory()

2019-12-19 Thread Fabiano Fidêncio
virGetUserDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio --- src/rpc/virnetclient.c | 12 src/rpc/virnettlscontext.c | 12 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/src/