Re: [libvirt] [PATCH 06/13] Turn virDomainObjPtr into a virObjectPtr

2012-08-02 Thread Daniel P. Berrange
On Thu, Aug 02, 2012 at 11:13:20AM +0100, Daniel P. Berrange wrote: > On Wed, Aug 01, 2012 at 04:39:24PM +0800, Hu Tao wrote: > > > void > > > virBlkioDeviceWeightArrayClear(virBlkioDeviceWeightPtr deviceWeights, > > > int ndevices) > > > @@ -723,7 +738,7 @@ virDom

Re: [libvirt] [PATCH 06/13] Turn virDomainObjPtr into a virObjectPtr

2012-08-02 Thread Daniel P. Berrange
On Wed, Aug 01, 2012 at 04:39:24PM +0800, Hu Tao wrote: > > void > > virBlkioDeviceWeightArrayClear(virBlkioDeviceWeightPtr deviceWeights, > > int ndevices) > > @@ -723,7 +738,7 @@ virDomainObjListDataFree(void *payload, const void > > *name ATTRIBUTE_UNUSED) > >

Re: [libvirt] [PATCH 06/13] Turn virDomainObjPtr into a virObjectPtr

2012-08-01 Thread Hu Tao
> void > virBlkioDeviceWeightArrayClear(virBlkioDeviceWeightPtr deviceWeights, > int ndevices) > @@ -723,7 +738,7 @@ virDomainObjListDataFree(void *payload, const void *name > ATTRIBUTE_UNUSED) > { > virDomainObjPtr obj = payload; > virDomainObjLock(obj

[libvirt] [PATCH 06/13] Turn virDomainObjPtr into a virObjectPtr

2012-07-31 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Switch virDomainObjPtr to use the virObject APIs for reference counting. The main change is that virObjectUnref does not return the reference count, merely a bool indicating whether the object still has any refs left. Checking the return value is also not mandatory. Si

Re: [libvirt] [PATCH 06/13] Turn virDomainObjPtr into a virObjectPtr

2012-07-17 Thread Eric Blake
On 07/11/2012 07:35 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Switch virDomainObjPtr to use the virObject APIs for reference > counting. The main change is that virObjectUnref does not return > the reference count, merely a bool indicating whether the object > still has any r

[libvirt] [PATCH 06/13] Turn virDomainObjPtr into a virObjectPtr

2012-07-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Switch virDomainObjPtr to use the virObject APIs for reference counting. The main change is that virObjectUnref does not return the reference count, merely a bool indicating whether the object still has any refs left. Checking the return value is also not mandatory. Si