Re: [libvirt] [PATCH 06/16] snapshot: Track current snapshot in virDomainSnapshotObjList

2019-03-21 Thread John Ferlan
On 3/21/19 3:58 PM, Eric Blake wrote: > On 3/20/19 4:03 PM, Eric Blake wrote: >> On 3/20/19 3:39 PM, John Ferlan wrote: >>> >>> >>> On 3/20/19 1:40 AM, Eric Blake wrote: It is easier to track the current snapshot as part of the list of snapshots. In particular, doing so lets us guarant

Re: [libvirt] [PATCH 06/16] snapshot: Track current snapshot in virDomainSnapshotObjList

2019-03-21 Thread Eric Blake
On 3/20/19 4:03 PM, Eric Blake wrote: > On 3/20/19 3:39 PM, John Ferlan wrote: >> >> >> On 3/20/19 1:40 AM, Eric Blake wrote: >>> It is easier to track the current snapshot as part of the list of >>> snapshots. In particular, doing so lets us guarantee that the current >>> snapshot is cleared if th

Re: [libvirt] [PATCH 06/16] snapshot: Track current snapshot in virDomainSnapshotObjList

2019-03-20 Thread Eric Blake
On 3/20/19 3:39 PM, John Ferlan wrote: > > > On 3/20/19 1:40 AM, Eric Blake wrote: >> It is easier to track the current snapshot as part of the list of >> snapshots. In particular, doing so lets us guarantee that the current >> snapshot is cleared if that snapshot is removed from the list (rather

Re: [libvirt] [PATCH 06/16] snapshot: Track current snapshot in virDomainSnapshotObjList

2019-03-20 Thread John Ferlan
On 3/20/19 1:40 AM, Eric Blake wrote: > It is easier to track the current snapshot as part of the list of > snapshots. In particular, doing so lets us guarantee that the current > snapshot is cleared if that snapshot is removed from the list (rather > than depending on the caller to do so, and r

[libvirt] [PATCH 06/16] snapshot: Track current snapshot in virDomainSnapshotObjList

2019-03-19 Thread Eric Blake
It is easier to track the current snapshot as part of the list of snapshots. In particular, doing so lets us guarantee that the current snapshot is cleared if that snapshot is removed from the list (rather than depending on the caller to do so, and risking a use-after-free problem). This requires