Re: [libvirt] [PATCH 08/10] util: error: Use a more declarative approach in virErrorMsg

2018-12-17 Thread Peter Krempa
On Mon, Dec 17, 2018 at 16:06:34 +, Daniel Berrange wrote: > On Thu, Dec 06, 2018 at 11:42:44AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 05, 2018 at 05:47:49PM +0100, Peter Krempa wrote: > > > Use a macro to declare how the strings for individual error codes. This > > > unifies the used

Re: [libvirt] [PATCH 08/10] util: error: Use a more declarative approach in virErrorMsg

2018-12-17 Thread Daniel P . Berrangé
On Thu, Dec 06, 2018 at 11:42:44AM +, Daniel P. Berrangé wrote: > On Wed, Dec 05, 2018 at 05:47:49PM +0100, Peter Krempa wrote: > > Use a macro to declare how the strings for individual error codes. This > > unifies the used condition and will allow simplifying the code further. > > > > Signed

Re: [libvirt] [PATCH 08/10] util: error: Use a more declarative approach in virErrorMsg

2018-12-06 Thread Peter Krempa
On Thu, Dec 06, 2018 at 11:48:15 +, Daniel Berrange wrote: > On Wed, Dec 05, 2018 at 05:47:49PM +0100, Peter Krempa wrote: > > Use a macro to declare how the strings for individual error codes. This > > unifies the used condition and will allow simplifying the code further. > > > > Signed-off-

Re: [libvirt] [PATCH 08/10] util: error: Use a more declarative approach in virErrorMsg

2018-12-06 Thread Peter Krempa
On Thu, Dec 06, 2018 at 11:42:44 +, Daniel Berrange wrote: > On Wed, Dec 05, 2018 at 05:47:49PM +0100, Peter Krempa wrote: > > Use a macro to declare how the strings for individual error codes. This > > unifies the used condition and will allow simplifying the code further. > > > > Signed-off-

Re: [libvirt] [PATCH 08/10] util: error: Use a more declarative approach in virErrorMsg

2018-12-06 Thread Daniel P . Berrangé
On Wed, Dec 05, 2018 at 05:47:49PM +0100, Peter Krempa wrote: > Use a macro to declare how the strings for individual error codes. This > unifies the used condition and will allow simplifying the code further. > > Signed-off-by: Peter Krempa > --- > src/libvirt_private.syms | 1 + > src/util/v

Re: [libvirt] [PATCH 08/10] util: error: Use a more declarative approach in virErrorMsg

2018-12-06 Thread Daniel P . Berrangé
On Wed, Dec 05, 2018 at 05:47:49PM +0100, Peter Krempa wrote: > Use a macro to declare how the strings for individual error codes. This > unifies the used condition and will allow simplifying the code further. > > Signed-off-by: Peter Krempa > --- > src/libvirt_private.syms | 1 + > src/util/v

Re: [libvirt] [PATCH 08/10] util: error: Use a more declarative approach in virErrorMsg

2018-12-06 Thread Peter Krempa
On Thu, Dec 06, 2018 at 12:29:27 +0100, Erik Skultety wrote: > On Wed, Dec 05, 2018 at 05:47:49PM +0100, Peter Krempa wrote: > > Use a macro to declare how the strings for individual error codes. This > > unifies the used condition and will allow simplifying the code further. > > > > Signed-off-by:

Re: [libvirt] [PATCH 08/10] util: error: Use a more declarative approach in virErrorMsg

2018-12-06 Thread Erik Skultety
On Wed, Dec 05, 2018 at 05:47:49PM +0100, Peter Krempa wrote: > Use a macro to declare how the strings for individual error codes. This > unifies the used condition and will allow simplifying the code further. > > Signed-off-by: Peter Krempa > --- > src/libvirt_private.syms | 1 + > src/util/vi

[libvirt] [PATCH 08/10] util: error: Use a more declarative approach in virErrorMsg

2018-12-05 Thread Peter Krempa
Use a macro to declare how the strings for individual error codes. This unifies the used condition and will allow simplifying the code further. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virerror.c | 792 +-- src/util/virer