Re: [libvirt] [PATCH 08/19] storage: Use consistent variable names for driver

2017-07-20 Thread John Ferlan
On 07/14/2017 11:07 AM, Pavel Hrdina wrote: > On Tue, May 09, 2017 at 11:30:15AM -0400, John Ferlan wrote: >> A virStoragePoolObjPtr will be an 'obj'. >> >> A virStoragePoolPtr will be a 'pool'. >> >> A virStorageVolPtr will be a 'vol'. >> >> A virStorageVolDefPtr will be a 'voldef'. >> >> Signed

Re: [libvirt] [PATCH 08/19] storage: Use consistent variable names for driver

2017-07-16 Thread John Ferlan
On 07/14/2017 09:53 AM, Pavel Hrdina wrote: > On Tue, May 09, 2017 at 11:30:15AM -0400, John Ferlan wrote: >> A virStoragePoolObjPtr will be an 'obj'. > > Now that I'm thinking about it, this should be poolObj or poolobj, it > would make it easier using git grep and also some functions takes mor

Re: [libvirt] [PATCH 08/19] storage: Use consistent variable names for driver

2017-07-14 Thread Pavel Hrdina
On Tue, May 09, 2017 at 11:30:15AM -0400, John Ferlan wrote: > A virStoragePoolObjPtr will be an 'obj'. > > A virStoragePoolPtr will be a 'pool'. > > A virStorageVolPtr will be a 'vol'. > > A virStorageVolDefPtr will be a 'voldef'. > > Signed-off-by: John Ferlan > --- > src/storage/storage_dr

Re: [libvirt] [PATCH 08/19] storage: Use consistent variable names for driver

2017-07-14 Thread Pavel Hrdina
On Tue, May 09, 2017 at 11:30:15AM -0400, John Ferlan wrote: > A virStoragePoolObjPtr will be an 'obj'. Now that I'm thinking about it, this should be poolObj or poolobj, it would make it easier using git grep and also some functions takes more than one object. We should thought about it earlier,

[libvirt] [PATCH 08/19] storage: Use consistent variable names for driver

2017-05-09 Thread John Ferlan
A virStoragePoolObjPtr will be an 'obj'. A virStoragePoolPtr will be a 'pool'. A virStorageVolPtr will be a 'vol'. A virStorageVolDefPtr will be a 'voldef'. Signed-off-by: John Ferlan --- src/storage/storage_driver.c | 1158 +- src/storage/storage_drive