Re: [libvirt] [PATCH 09/11] storage_scsi: Allow the direct PCI address for 'parent'

2013-06-20 Thread Osier Yang
On 20/06/13 15:04, Ján Tomko wrote: On 06/20/2013 05:21 AM, Osier Yang wrote: On 20/06/13 02:28, John Ferlan wrote: On 06/07/2013 01:16 PM, Osier Yang wrote: On 08/06/13 01:03, Osier Yang wrote: return NULL; } -if (!(tokens = virStringSplit(parent, "_", 0))) -

Re: [libvirt] [PATCH 09/11] storage_scsi: Allow the direct PCI address for 'parent'

2013-06-20 Thread Ján Tomko
On 06/20/2013 05:21 AM, Osier Yang wrote: > On 20/06/13 02:28, John Ferlan wrote: >> On 06/07/2013 01:16 PM, Osier Yang wrote: >>> On 08/06/13 01:03, Osier Yang wrote: >> return NULL; } -if (!(tokens = virStringSplit(parent, "_", 0))) -return NUL

Re: [libvirt] [PATCH 09/11] storage_scsi: Allow the direct PCI address for 'parent'

2013-06-19 Thread Osier Yang
On 20/06/13 02:28, John Ferlan wrote: On 06/07/2013 01:16 PM, Osier Yang wrote: On 08/06/13 01:03, Osier Yang wrote: To be more flexible, except allowing to specify 'parent' with name produced by node device udev/HAL backends, this supports to specify 'parent' with PCI address directly (e.g. 0

Re: [libvirt] [PATCH 09/11] storage_scsi: Allow the direct PCI address for 'parent'

2013-06-19 Thread John Ferlan
On 06/07/2013 01:16 PM, Osier Yang wrote: > On 08/06/13 01:03, Osier Yang wrote: >> To be more flexible, except allowing to specify 'parent' with name >> produced by node device udev/HAL backends, this supports to specify >> 'parent' with PCI address directly (e.g. :00:1f:2). The specified >>

Re: [libvirt] [PATCH 09/11] storage_scsi: Allow the direct PCI address for 'parent'

2013-06-07 Thread Osier Yang
On 08/06/13 01:03, Osier Yang wrote: To be more flexible, except allowing to specify 'parent' with name produced by node device udev/HAL backends, this supports to specify 'parent' with PCI address directly (e.g. :00:1f:2). The specified address will be padded if it's not consistent with wha

[libvirt] [PATCH 09/11] storage_scsi: Allow the direct PCI address for 'parent'

2013-06-07 Thread Osier Yang
To be more flexible, except allowing to specify 'parent' with name produced by node device udev/HAL backends, this supports to specify 'parent' with PCI address directly (e.g. :00:1f:2). The specified address will be padded if it's not consistent with what sysfs exposed. (e.g 0:0:2:2 will be p