Re: [libvirt] [PATCH 1/2] Always free the device in AttachChrDevice

2015-01-27 Thread Ján Tomko
On 01/27/2015 04:27 PM, Michal Privoznik wrote: > On 27.01.2015 14:45, Ján Tomko wrote: >> Do not free it in the caller (qemuDomainAttachDeviceFlags), >> because it has no way of knowing if it hasn't been cleaned >> up by qemuProcessStop on monitor EOF. >> >> https://bugzilla.redhat.com/show_bug.cg

Re: [libvirt] [PATCH 1/2] Always free the device in AttachChrDevice

2015-01-27 Thread Michal Privoznik
On 27.01.2015 14:45, Ján Tomko wrote: > Do not free it in the caller (qemuDomainAttachDeviceFlags), > because it has no way of knowing if it hasn't been cleaned > up by qemuProcessStop on monitor EOF. > > https://bugzilla.redhat.com/show_bug.cgi?id=1161024 > --- > src/qemu/qemu_driver.c | 3 +--

[libvirt] [PATCH 1/2] Always free the device in AttachChrDevice

2015-01-27 Thread Ján Tomko
Do not free it in the caller (qemuDomainAttachDeviceFlags), because it has no way of knowing if it hasn't been cleaned up by qemuProcessStop on monitor EOF. https://bugzilla.redhat.com/show_bug.cgi?id=1161024 --- src/qemu/qemu_driver.c | 3 +-- src/qemu/qemu_hotplug.c | 14 ++ tests