Re: [libvirt] [PATCH 1/2] Move struct _virPCIDevice definition from virpci.c to virpci.h

2015-01-14 Thread Shivaprasad bhat
Thanks for the comments Michal. I just posted the v2 for review. Regards. Shiva On Mon, Jan 12, 2015 at 2:43 PM, Michal Privoznik wrote: > On 04.12.2014 08:27, Shivaprasad G Bhat wrote: >> >> The struct members can't be referenced from files including the .h. >> Moving the definition to .h from

Re: [libvirt] [PATCH 1/2] Move struct _virPCIDevice definition from virpci.c to virpci.h

2015-01-12 Thread Michal Privoznik
On 04.12.2014 08:27, Shivaprasad G Bhat wrote: The struct members can't be referenced from files including the .h. Moving the definition to .h from .c helps referencing the members. The patch is just the struct definition code movement. Signed-off-by: Shivaprasad G Bhat --- src/util/virpci.c

[libvirt] [PATCH 1/2] Move struct _virPCIDevice definition from virpci.c to virpci.h

2014-12-03 Thread Shivaprasad G Bhat
The struct members can't be referenced from files including the .h. Moving the definition to .h from .c helps referencing the members. The patch is just the struct definition code movement. Signed-off-by: Shivaprasad G Bhat --- src/util/virpci.c | 29 - src/util/vir