Re: [libvirt] [PATCH 1/2] VirtualBox support to libvirt

2009-03-24 Thread Pritesh Kothari
Hi Daniel, > > +VBOX_DRIVER_SOURCES = \ > > +vbox/VBoxXPCOMCGlue.c vbox/VBoxXPCOMCGlue.h \ > > +vbox/vbox_driver.c vbox/vbox_driver.h \ > > +vbox/vbox_V2_2.c > > Another thing, it would be better to have all the driver filenames > start

Re: [libvirt] [PATCH 1/2] VirtualBox support to libvirt

2009-03-24 Thread Daniel Veillard
On Wed, Mar 18, 2009 at 06:44:31PM +0100, Pritesh Kothari wrote: [...] > +VBOX_DRIVER_SOURCES = \ > +vbox/VBoxXPCOMCGlue.c vbox/VBoxXPCOMCGlue.h \ > +vbox/vbox_driver.c vbox/vbox_driver.h \ > +vbox/vbox_V2_2.c Another thing, it would be

Re: [libvirt] [PATCH 1/2] VirtualBox support to libvirt

2009-03-23 Thread Daniel P. Berrange
On Wed, Mar 18, 2009 at 06:44:31PM +0100, Pritesh Kothari wrote: > Hi All, > > I have attached a patch which when applied on the HEAD as of today would > allow virtualbox support in libvirt. > > The patch works very well with the VirtualBox OSE version and the 2.2 Beta > release. > > [PATCH 1/2

Re: [libvirt] [PATCH 1/2] VirtualBox support to libvirt

2009-03-19 Thread Daniel Veillard
On Thu, Mar 19, 2009 at 02:12:21PM +0100, Pritesh Kothari wrote: > Hi Daniel, > > > > > > +VBOX_DRIVER_SOURCES = \ > > > +vbox/VBoxXPCOMCGlue.c vbox/VBoxXPCOMCGlue.h \ > > > +vbox/vbox_driver.c vbox/vbox_driver.h \ > > > +vbox/vbox_V2_2.c

Re: [libvirt] [PATCH 1/2] VirtualBox support to libvirt

2009-03-19 Thread Pritesh Kothari
Hi Daniel, > > > +VBOX_DRIVER_SOURCES = \ > > +vbox/VBoxXPCOMCGlue.c vbox/VBoxXPCOMCGlue.h \ > > +vbox/vbox_driver.c vbox/vbox_driver.h \ > > +vbox/vbox_V2_2.c > > Hum, I wonder about the need of a subdirectory here, others > drivers ar

Re: [libvirt] [PATCH 1/2] VirtualBox support to libvirt

2009-03-19 Thread Daniel Veillard
On Wed, Mar 18, 2009 at 06:44:31PM +0100, Pritesh Kothari wrote: > Hi All, > > I have attached a patch which when applied on the HEAD as of today would > allow virtualbox support in libvirt. > > The patch works very well with the VirtualBox OSE version and the 2.2 Beta > release. Cool, thanks

[libvirt] [PATCH 1/2] VirtualBox support to libvirt

2009-03-18 Thread Pritesh Kothari
Hi All, I have attached a patch which when applied on the HEAD as of today would allow virtualbox support in libvirt. The patch works very well with the VirtualBox OSE version and the 2.2 Beta release. [PATCH 1/2] contains diff of files already in libvirt. [PATCH 2/2] contains new files needed