Re: [libvirt] [PATCH 1/2] bhyve: fix crash in bhyveBuildNetArgStr

2014-06-13 Thread Roman Bogorodskiy
Eric Blake wrote: > On 06/13/2014 10:48 AM, Roman Bogorodskiy wrote: > > bhyveBuildNetArgStr() calls virNetDevTapCreateInBridgePort() and > > passes tapfd = NULL, but tapfdSize = 1. That is wrong, because > > if virNetDevTapCreateInBridgePort() crashes after successfully > > creating a TAP devic

Re: [libvirt] [PATCH 1/2] bhyve: fix crash in bhyveBuildNetArgStr

2014-06-13 Thread Eric Blake
On 06/13/2014 10:48 AM, Roman Bogorodskiy wrote: > bhyveBuildNetArgStr() calls virNetDevTapCreateInBridgePort() and > passes tapfd = NULL, but tapfdSize = 1. That is wrong, because > if virNetDevTapCreateInBridgePort() crashes after successfully > creating a TAP device, it'll jump to 'error' label,

[libvirt] [PATCH 1/2] bhyve: fix crash in bhyveBuildNetArgStr

2014-06-13 Thread Roman Bogorodskiy
bhyveBuildNetArgStr() calls virNetDevTapCreateInBridgePort() and passes tapfd = NULL, but tapfdSize = 1. That is wrong, because if virNetDevTapCreateInBridgePort() crashes after successfully creating a TAP device, it'll jump to 'error' label, that loops over tapfd and calls VIR_FORCE_CLOSE: for