Eric Blake wrote:
> On 06/13/2014 10:48 AM, Roman Bogorodskiy wrote:
> > bhyveBuildNetArgStr() calls virNetDevTapCreateInBridgePort() and
> > passes tapfd = NULL, but tapfdSize = 1. That is wrong, because
> > if virNetDevTapCreateInBridgePort() crashes after successfully
> > creating a TAP devic
On 06/13/2014 10:48 AM, Roman Bogorodskiy wrote:
> bhyveBuildNetArgStr() calls virNetDevTapCreateInBridgePort() and
> passes tapfd = NULL, but tapfdSize = 1. That is wrong, because
> if virNetDevTapCreateInBridgePort() crashes after successfully
> creating a TAP device, it'll jump to 'error' label,
bhyveBuildNetArgStr() calls virNetDevTapCreateInBridgePort() and
passes tapfd = NULL, but tapfdSize = 1. That is wrong, because
if virNetDevTapCreateInBridgePort() crashes after successfully
creating a TAP device, it'll jump to 'error' label, that
loops over tapfd and calls VIR_FORCE_CLOSE:
for