Re: [libvirt] [PATCH 1/2] conf: Fix crash in virDomainDefCompatibleDevice

2018-03-01 Thread Jiri Denemark
On Thu, Mar 01, 2018 at 08:03:38 -0500, John Ferlan wrote: > Commit id 'edae027c' blindly assumed that the passed @oldDev > parameter would not be NULL when calling virDomainDeviceGetInfo; > however, commit id 'b6a264e8' passed NULL for AttachDevice > callers under the premise that there wouldn't b

[libvirt] [PATCH 1/2] conf: Fix crash in virDomainDefCompatibleDevice

2018-03-01 Thread John Ferlan
Commit id 'edae027c' blindly assumed that the passed @oldDev parameter would not be NULL when calling virDomainDeviceGetInfo; however, commit id 'b6a264e8' passed NULL for AttachDevice callers under the premise that there wouldn't be a device to check/update against. Signed-off-by: John Ferlan --