Re: [libvirt] [PATCH 1/2] storage: Don't delete Ploop volumes twice

2016-07-15 Thread Martin Kletzander
On Fri, Jul 15, 2016 at 02:51:21PM +0300, Olga Krishtal wrote: On 15/07/16 11:37, Martin Kletzander wrote: On Fri, Jul 15, 2016 at 09:41:11AM +0200, Ján Tomko wrote: On Thu, Jul 14, 2016 at 02:27:40PM +0200, Martin Kletzander wrote: When reinitializing Ploop volumes we also went through the ru

Re: [libvirt] [PATCH 1/2] storage: Don't delete Ploop volumes twice

2016-07-15 Thread Olga Krishtal
On 15/07/16 11:37, Martin Kletzander wrote: On Fri, Jul 15, 2016 at 09:41:11AM +0200, Ján Tomko wrote: On Thu, Jul 14, 2016 at 02:27:40PM +0200, Martin Kletzander wrote: When reinitializing Ploop volumes we also went through the rutine of the normal wipe, effectively removing the root.hds file

Re: [libvirt] [PATCH 1/2] storage: Don't delete Ploop volumes twice

2016-07-15 Thread Martin Kletzander
On Fri, Jul 15, 2016 at 09:41:11AM +0200, Ján Tomko wrote: On Thu, Jul 14, 2016 at 02:27:40PM +0200, Martin Kletzander wrote: When reinitializing Ploop volumes we also went through the rutine of the normal wipe, effectively removing the root.hds file twice. The file was wiped with the selected

Re: [libvirt] [PATCH 1/2] storage: Don't delete Ploop volumes twice

2016-07-15 Thread Ján Tomko
On Thu, Jul 14, 2016 at 02:27:40PM +0200, Martin Kletzander wrote: When reinitializing Ploop volumes we also went through the rutine of the normal wipe, effectively removing the root.hds file twice. The file was wiped with the selected algorithm first (without deletion), then reinitialized to m

[libvirt] [PATCH 1/2] storage: Don't delete Ploop volumes twice

2016-07-14 Thread Martin Kletzander
When reinitializing Ploop volumes we also went through the rutine of the normal wipe, effectively removing the root.hds file twice. Since we'll hopefully add support for other formats as well, split the function with a switch into which we can cleanly add formats in the future. Signed-off-by: Mar