Re: [libvirt] [PATCH 1/2] util: guarantee sane errno in virFileIsExecutable

2011-03-21 Thread Eric Blake
On 03/19/2011 07:54 AM, Matthias Bolte wrote: > 2011/3/18 Eric Blake : >> If virFileIsExecutable is to replace access(file,X_OK), then >> errno must be usable on failure. >> >> * src/util/util.c (virFileIsExecutable): Set errno on failure. >> --- >> > > ACK. Thanks; pushed. Did you also get to l

Re: [libvirt] [PATCH 1/2] util: guarantee sane errno in virFileIsExecutable

2011-03-19 Thread Matthias Bolte
2011/3/18 Eric Blake : > If virFileIsExecutable is to replace access(file,X_OK), then > errno must be usable on failure. > > * src/util/util.c (virFileIsExecutable): Set errno on failure. > --- > ACK. Matthias -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/list

[libvirt] [PATCH 1/2] util: guarantee sane errno in virFileIsExecutable

2011-03-18 Thread Eric Blake
If virFileIsExecutable is to replace access(file,X_OK), then errno must be usable on failure. * src/util/util.c (virFileIsExecutable): Set errno on failure. --- src/util/util.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/util/util.c b/src/util/util.c i