Re: [libvirt] [PATCH 1/2] virPerfReadEvent: Prefer saferead over read

2016-03-31 Thread Ján Tomko
On Thu, Mar 31, 2016 at 04:48:23PM +0200, Michal Privoznik wrote: > Do I really need to explain why? Do you really need to ask? > Well, if read() is interrupted int the middle of reading, we will > never read the rest (even though it's highly unlikely as we are > reading just 8 bytes). > > Signe

[libvirt] [PATCH 1/2] virPerfReadEvent: Prefer saferead over read

2016-03-31 Thread Michal Privoznik
Do I really need to explain why? Well, if read() is interrupted int the middle of reading, we will never read the rest (even though it's highly unlikely as we are reading just 8 bytes). Signed-off-by: Michal Privoznik --- src/util/virperf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)