Re: [libvirt] [PATCH 1/2] virt-yajl.m4: Drop useless check for qemu

2019-03-14 Thread Ján Tomko
On Wed, Mar 13, 2019 at 04:50:37PM +0100, Michal Privoznik wrote: Firstly, this code is lacking AC_REQUIRE() therefore it may happen that this code is executed before LIBVIRT_DRIVER_CHECK_QEMU is evaluated. Irrelevant. LIBVIRT_DRIVER_CHECK_QEMU does not actually change the with_qemu variable. I

[libvirt] [PATCH 1/2] virt-yajl.m4: Drop useless check for qemu

2019-03-13 Thread Michal Privoznik
Firstly, this code is lacking AC_REQUIRE() therefore it may happen that this code is executed before LIBVIRT_DRIVER_CHECK_QEMU is evaluated. Secondly, the code tries to detect installed version of qemu to learn if it uses HMP or QMP and enable YAJL based on that. Well, we support only QMP and also