Re: [libvirt] [PATCH 1/3] storage: Resolve Coverity FORWARD_NULL

2015-05-23 Thread Laine Stump
On 05/14/2015 08:35 AM, John Ferlan wrote: > > On 05/13/2015 02:43 PM, Jiri Denemark wrote: >> On Wed, May 13, 2015 at 12:32:20 -0400, John Ferlan wrote: >>> Coverity points out it's possible for one of the virCommand{Output|Error}* >>> API's to have not allocated 'output' and/or 'error' in which c

Re: [libvirt] [PATCH 1/3] storage: Resolve Coverity FORWARD_NULL

2015-05-14 Thread John Ferlan
On 05/13/2015 02:43 PM, Jiri Denemark wrote: > On Wed, May 13, 2015 at 12:32:20 -0400, John Ferlan wrote: >> Coverity points out it's possible for one of the virCommand{Output|Error}* >> API's to have not allocated 'output' and/or 'error' in which case the >> strstr comparison will cause a NULL d

Re: [libvirt] [PATCH 1/3] storage: Resolve Coverity FORWARD_NULL

2015-05-13 Thread Jiri Denemark
On Wed, May 13, 2015 at 12:32:20 -0400, John Ferlan wrote: > Coverity points out it's possible for one of the virCommand{Output|Error}* > API's to have not allocated 'output' and/or 'error' in which case the > strstr comparison will cause a NULL deref > > Signed-off-by: John Ferlan > --- > src/s

[libvirt] [PATCH 1/3] storage: Resolve Coverity FORWARD_NULL

2015-05-13 Thread John Ferlan
Coverity points out it's possible for one of the virCommand{Output|Error}* API's to have not allocated 'output' and/or 'error' in which case the strstr comparison will cause a NULL deref Signed-off-by: John Ferlan --- src/storage/storage_backend_disk.c | 2 +- 1 file changed, 1 insertion(+), 1 d