Re: [libvirt] [PATCH 1/3] virNetDevMacVLanCreateWithVPortProfile: Don't mask virNetDevMacVLanTapOpen error

2016-08-10 Thread Ján Tomko
On Tue, Aug 09, 2016 at 07:32:43PM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1240439 In this function we create a macvtap device and open its tap device. Possibly multiple times. Possibly multiple devices? Multiple times sounds like it's the same device. Not

[libvirt] [PATCH 1/3] virNetDevMacVLanCreateWithVPortProfile: Don't mask virNetDevMacVLanTapOpen error

2016-08-09 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1240439 In this function we create a macvtap device and open its tap device. Possibly multiple times. Not the thing is, if opening the tap device fails, that is virNetDevMacVLanTapOpen() returns a negative value, we unroll all the changes BUT return 0 fo