Re: [libvirt] [PATCH 1/3] virjsontest: introduce DO_TEST_PARSE_FILE

2019-02-13 Thread Andrea Bolognani
On Wed, 2019-02-13 at 15:07 +0100, Ján Tomko wrote: > On Wed, Feb 13, 2019 at 02:18:32PM +0100, Andrea Bolognani wrote: > > Are the backslashes at the end of lines necessary? > > In this patch? Yes. The aim is to preserve the test coverage done before > and after. > > > I've tried > > removing a

Re: [libvirt] [PATCH 1/3] virjsontest: introduce DO_TEST_PARSE_FILE

2019-02-13 Thread Ján Tomko
On Wed, Feb 13, 2019 at 02:18:32PM +0100, Andrea Bolognani wrote: On Tue, 2019-02-12 at 16:57 +0100, Ján Tomko wrote: [...] +{"return": [{"filename": \ +"unix:/home/berrange/.libvirt/qemu/lib/tck.monitor,server",\ +"label": "charmonitor"}, {"filename": "pty:/dev/pts/158",\ +"label": "charserial0

Re: [libvirt] [PATCH 1/3] virjsontest: introduce DO_TEST_PARSE_FILE

2019-02-13 Thread Andrea Bolognani
On Tue, 2019-02-12 at 16:57 +0100, Ján Tomko wrote: [...] > +{"return": [{"filename": \ > +"unix:/home/berrange/.libvirt/qemu/lib/tck.monitor,server",\ > +"label": "charmonitor"}, {"filename": "pty:/dev/pts/158",\ > +"label": "charserial0"}], "id": "libvirt-3"} Are the backslashes at the end of li

[libvirt] [PATCH 1/3] virjsontest: introduce DO_TEST_PARSE_FILE

2019-02-12 Thread Ján Tomko
Introduce a new macro DO_TEST_PARSE_FILE which takes the input JSON from a file instead of a C string. This lets us get rid of quote escaping and makes the JSON easier to edit. The output JSON is still taken from a string and will be moved separately. Signed-off-by: Ján Tomko --- tests/virjson