Re: [libvirt] [PATCH 1/4] build: yet another cgroup conditional compilation fix

2013-07-29 Thread Eric Blake
On 07/29/2013 09:09 AM, Daniel P. Berrange wrote: > On Mon, Jul 29, 2013 at 08:53:35AM -0600, Eric Blake wrote: >> From: "Daniel P. Berrange" >> >> >> -static int virCgroupPartitionEscape(char **path); >> - >> bool virCgroupAvailable(void) >> { >> bool ret = false; >> @@ -95,6 +93,10 @@ bo

Re: [libvirt] [PATCH 1/4] build: yet another cgroup conditional compilation fix

2013-07-29 Thread Daniel P. Berrange
On Mon, Jul 29, 2013 at 08:53:35AM -0600, Eric Blake wrote: > From: "Daniel P. Berrange" > > Linking fails on FreeBSD: >CCLD libvirt.la > /usr/bin/ld: ./.libs/libvirt_util.a(libvirt_util_la-vircgroup.o): > relocation R_X86_64_PC32 against `virCgroupPartitionEscape' can not be > used

[libvirt] [PATCH 1/4] build: yet another cgroup conditional compilation fix

2013-07-29 Thread Eric Blake
From: "Daniel P. Berrange" Linking fails on FreeBSD: CCLD libvirt.la /usr/bin/ld: ./.libs/libvirt_util.a(libvirt_util_la-vircgroup.o): relocation R_X86_64_PC32 against `virCgroupPartitionEscape' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final li