Re: [libvirt] [PATCH 1/4] qemu: Automatically choose usable GIC version

2016-05-13 Thread Cole Robinson
On 05/12/2016 11:53 AM, Andrea Bolognani wrote: > On Tue, 2016-05-10 at 18:42 -0400, Cole Robinson wrote: >>> >>> +if (virQEMUCapsFillDomainCaps(caps, qemuCaps, NULL, 0) < 0) >>> +goto cleanup; >>> + >>> +gic = &(caps->gic); >>> + >>> +/* Pick the best GIC vers

Re: [libvirt] [PATCH 1/4] qemu: Automatically choose usable GIC version

2016-05-12 Thread Andrea Bolognani
On Tue, 2016-05-10 at 18:42 -0400, Cole Robinson wrote: > >  > > +if (virQEMUCapsFillDomainCaps(caps, qemuCaps, NULL, 0) < 0) > > +goto cleanup; > > + > > +gic = &(caps->gic); > > + > > +/* Pick the best GIC version from those available */ > > +if (gic->s

Re: [libvirt] [PATCH 1/4] qemu: Automatically choose usable GIC version

2016-05-11 Thread Michal Privoznik
On 11.05.2016 00:42, Cole Robinson wrote: > On 05/10/2016 08:46 AM, Andrea Bolognani wrote: >> When the element in not present in the domain XML, use the >> domain capabilities to figure out what GIC version is usable and >> choose that one automatically. >> >> This allows guests to be created on

Re: [libvirt] [PATCH 1/4] qemu: Automatically choose usable GIC version

2016-05-10 Thread Cole Robinson
On 05/10/2016 08:46 AM, Andrea Bolognani wrote: > When the element in not present in the domain XML, use the > domain capabilities to figure out what GIC version is usable and > choose that one automatically. > > This allows guests to be created on hardware that only supports > GIC v3 without hav

[libvirt] [PATCH 1/4] qemu: Automatically choose usable GIC version

2016-05-10 Thread Andrea Bolognani
When the element in not present in the domain XML, use the domain capabilities to figure out what GIC version is usable and choose that one automatically. This allows guests to be created on hardware that only supports GIC v3 without having to update virt-manager and similar tools. Keep using th