Re: [libvirt] [PATCH 1/4] security: Grab a reference to virSecurityManager for transactions

2018-09-25 Thread John Ferlan
On 9/21/18 5:29 AM, Michal Privoznik wrote: > This shouldn't be needed per-se. Security manager shouldn't > disappear during transactions - it's immutable. However, it > doesn't hurt to grab a reference either - transaction code uses > it after all. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH 1/4] security: Grab a reference to virSecurityManager for transactions

2018-09-21 Thread Marc Hartmayer
On Fri, Sep 21, 2018 at 11:29 AM +0200, Michal Privoznik wrote: > This shouldn't be needed per-se. Security manager shouldn't > disappear during transactions - it's immutable. However, it > doesn't hurt to grab a reference either - transaction code uses > it after all. > > Signed-off-by: Michal P

[libvirt] [PATCH 1/4] security: Grab a reference to virSecurityManager for transactions

2018-09-21 Thread Michal Privoznik
This shouldn't be needed per-se. Security manager shouldn't disappear during transactions - it's immutable. However, it doesn't hurt to grab a reference either - transaction code uses it after all. Signed-off-by: Michal Privoznik --- src/security/security_dac.c | 5 +++-- src/security/securi