Re: [libvirt] [PATCH 1/5] conf: avoid memleak on NULL path

2014-04-07 Thread Eric Blake
On 04/07/2014 02:22 AM, Peter Krempa wrote: > On 04/06/14 05:32, Eric Blake wrote: >> I noticed that the apparmor code could request metadata even >> for a cdrom with no media, which would cause a memory leak of >> the hash table used to look for loops in the backing chain. >> But even before that,

Re: [libvirt] [PATCH 1/5] conf: avoid memleak on NULL path

2014-04-07 Thread Peter Krempa
On 04/06/14 05:32, Eric Blake wrote: > I noticed that the apparmor code could request metadata even > for a cdrom with no media, which would cause a memory leak of > the hash table used to look for loops in the backing chain. > But even before that, we blindly dereferenced the path for > printing a

[libvirt] [PATCH 1/5] conf: avoid memleak on NULL path

2014-04-05 Thread Eric Blake
I noticed that the apparmor code could request metadata even for a cdrom with no media, which would cause a memory leak of the hash table used to look for loops in the backing chain. But even before that, we blindly dereferenced the path for printing a debug statement, so it is just better to enfor