Re: [libvirt] [PATCH 1/5] qemuBuildMachineCommandLine: Follow our pattern

2016-08-04 Thread Pavel Hrdina
On Wed, Jul 27, 2016 at 10:43:48AM +0200, Michal Privoznik wrote: > We use 'goto cleanup' for a reason. If a function can exit at > many places but doesn't follow the pattern, it has to copy the > free code in multiple places. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_command.c |

[libvirt] [PATCH 1/5] qemuBuildMachineCommandLine: Follow our pattern

2016-07-27 Thread Michal Privoznik
We use 'goto cleanup' for a reason. If a function can exit at many places but doesn't follow the pattern, it has to copy the free code in multiple places. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 39 ++- 1 file changed, 18 insertions(+), 2