Re: [libvirt] [PATCH 1/5] qemuDomainDetachChrDevice: Use @tmpChr to build device string

2019-02-12 Thread John Ferlan
$SUBJ: qemu: Use @tmpChr in qemuDomainDetachChrDevice to build device string On 2/11/19 10:40 AM, Michal Privoznik wrote: > So far we are passing @chr to qemuBuildChrDeviceStr. This is > suboptimal beacuse @chr is just parsed XML definition provided by because > user which by definition may l

[libvirt] [PATCH 1/5] qemuDomainDetachChrDevice: Use @tmpChr to build device string

2019-02-11 Thread Michal Privoznik
So far we are passing @chr to qemuBuildChrDeviceStr. This is suboptimal beacuse @chr is just parsed XML definition provided by user which by definition may lack some information. On the other hand, @tmpChr is the one that was found using @chr in domain definition so it contains the same amount of i