Re: [libvirt] [PATCH 1/5] virDomainNumaGetNodeDistance: Fix input arguments validation

2017-11-22 Thread John Ferlan
On 11/22/2017 04:45 AM, Michal Privoznik wrote: > On 11/22/2017 12:22 AM, John Ferlan wrote: >> >> >> On 11/14/2017 09:47 AM, Michal Privoznik wrote: >>> There's no point in checking if numa->mem_nodes[node].ndistances >>> is set if we check for numa->mem_nodes[node].distances. However, >>> it ma

Re: [libvirt] [PATCH 1/5] virDomainNumaGetNodeDistance: Fix input arguments validation

2017-11-22 Thread Michal Privoznik
On 11/22/2017 12:22 AM, John Ferlan wrote: > > > On 11/14/2017 09:47 AM, Michal Privoznik wrote: >> There's no point in checking if numa->mem_nodes[node].ndistances >> is set if we check for numa->mem_nodes[node].distances. However, >> it makes sense to check if the sibling node caller passed fal

Re: [libvirt] [PATCH 1/5] virDomainNumaGetNodeDistance: Fix input arguments validation

2017-11-21 Thread John Ferlan
On 11/14/2017 09:47 AM, Michal Privoznik wrote: > There's no point in checking if numa->mem_nodes[node].ndistances > is set if we check for numa->mem_nodes[node].distances. However, > it makes sense to check if the sibling node caller passed falls > within boundaries. > > Signed-off-by: Michal P

[libvirt] [PATCH 1/5] virDomainNumaGetNodeDistance: Fix input arguments validation

2017-11-14 Thread Michal Privoznik
There's no point in checking if numa->mem_nodes[node].ndistances is set if we check for numa->mem_nodes[node].distances. However, it makes sense to check if the sibling node caller passed falls within boundaries. Signed-off-by: Michal Privoznik --- src/conf/numa_conf.c | 2 +- 1 file changed, 1