Re: [libvirt] [PATCH 1/6] port allocator: make used port bitmap global

2018-02-05 Thread Michal Privoznik
On 02/05/2018 02:21 PM, Daniel P. Berrangé wrote: > On Mon, Feb 05, 2018 at 02:11:24PM +0100, Peter Krempa wrote: >> On Mon, Feb 05, 2018 at 12:55:11 +, Daniel Berrange wrote: >>> On Mon, Feb 05, 2018 at 01:39:56PM +0100, Michal Privoznik wrote: On 02/01/2018 08:51 AM, Nikolay Shirokovskiy

Re: [libvirt] [PATCH 1/6] port allocator: make used port bitmap global

2018-02-05 Thread Nikolay Shirokovskiy
On 05.02.2018 16:27, Michal Privoznik wrote: > On 02/05/2018 02:21 PM, Daniel P. Berrangé wrote: >> On Mon, Feb 05, 2018 at 02:11:24PM +0100, Peter Krempa wrote: >>> On Mon, Feb 05, 2018 at 12:55:11 +, Daniel Berrange wrote: On Mon, Feb 05, 2018 at 01:39:56PM +0100, Michal Privoznik wrot

Re: [libvirt] [PATCH 1/6] port allocator: make used port bitmap global

2018-02-05 Thread Daniel P . Berrangé
On Mon, Feb 05, 2018 at 02:11:24PM +0100, Peter Krempa wrote: > On Mon, Feb 05, 2018 at 12:55:11 +, Daniel Berrange wrote: > > On Mon, Feb 05, 2018 at 01:39:56PM +0100, Michal Privoznik wrote: > > > On 02/01/2018 08:51 AM, Nikolay Shirokovskiy wrote: > > > > > > > > > > > > On 29.01.2018 09:0

Re: [libvirt] [PATCH 1/6] port allocator: make used port bitmap global

2018-02-05 Thread Peter Krempa
On Mon, Feb 05, 2018 at 12:55:11 +, Daniel Berrange wrote: > On Mon, Feb 05, 2018 at 01:39:56PM +0100, Michal Privoznik wrote: > > On 02/01/2018 08:51 AM, Nikolay Shirokovskiy wrote: > > > > > > > > > On 29.01.2018 09:09, Michal Privoznik wrote: > > >> On 12/20/2017 07:35 AM, Nikolay Shirokov

Re: [libvirt] [PATCH 1/6] port allocator: make used port bitmap global

2018-02-05 Thread Daniel P . Berrangé
On Mon, Feb 05, 2018 at 01:39:56PM +0100, Michal Privoznik wrote: > On 02/01/2018 08:51 AM, Nikolay Shirokovskiy wrote: > > > > > > On 29.01.2018 09:09, Michal Privoznik wrote: > >> On 12/20/2017 07:35 AM, Nikolay Shirokovskiy wrote: > >>> Host tcp4/tcp6 ports is a global resource thus we need to

Re: [libvirt] [PATCH 1/6] port allocator: make used port bitmap global

2018-02-05 Thread Michal Privoznik
On 02/01/2018 08:51 AM, Nikolay Shirokovskiy wrote: > > > On 29.01.2018 09:09, Michal Privoznik wrote: >> On 12/20/2017 07:35 AM, Nikolay Shirokovskiy wrote: >>> Host tcp4/tcp6 ports is a global resource thus we need to make >>> port accounting also global or we have issues described in [1] when

Re: [libvirt] [PATCH 1/6] port allocator: make used port bitmap global

2018-01-31 Thread Nikolay Shirokovskiy
On 29.01.2018 09:09, Michal Privoznik wrote: > On 12/20/2017 07:35 AM, Nikolay Shirokovskiy wrote: >> Host tcp4/tcp6 ports is a global resource thus we need to make >> port accounting also global or we have issues described in [1] when >> port allocator ranges of different instances are overlappe

Re: [libvirt] [PATCH 1/6] port allocator: make used port bitmap global

2018-01-29 Thread Michal Privoznik
On 01/29/2018 12:07 PM, Peter Krempa wrote: > On Mon, Jan 29, 2018 at 07:09:54 +0100, Michal Privoznik wrote: >> On 12/20/2017 07:35 AM, Nikolay Shirokovskiy wrote: >>> Host tcp4/tcp6 ports is a global resource thus we need to make >>> port accounting also global or we have issues described in [1]

Re: [libvirt] [PATCH 1/6] port allocator: make used port bitmap global

2018-01-29 Thread Peter Krempa
On Mon, Jan 29, 2018 at 07:09:54 +0100, Michal Privoznik wrote: > On 12/20/2017 07:35 AM, Nikolay Shirokovskiy wrote: > > Host tcp4/tcp6 ports is a global resource thus we need to make > > port accounting also global or we have issues described in [1] when > > port allocator ranges of different ins

Re: [libvirt] [PATCH 1/6] port allocator: make used port bitmap global

2018-01-28 Thread Michal Privoznik
On 12/20/2017 07:35 AM, Nikolay Shirokovskiy wrote: > Host tcp4/tcp6 ports is a global resource thus we need to make > port accounting also global or we have issues described in [1] when > port allocator ranges of different instances are overlapped (which > is by default for qemu for example). > >

[libvirt] [PATCH 1/6] port allocator: make used port bitmap global

2017-12-19 Thread Nikolay Shirokovskiy
Host tcp4/tcp6 ports is a global resource thus we need to make port accounting also global or we have issues described in [1] when port allocator ranges of different instances are overlapped (which is by default for qemu for example). Let's have only one global port allocator object that take care