Re: [libvirt] [PATCH 1/9] util: new functions for setting bridge and bridge port attributes

2014-11-24 Thread Eric Blake
On 11/24/2014 01:36 PM, John Ferlan wrote: > > > On 11/24/2014 12:48 PM, Laine Stump wrote: >> These functions all set/get items in the sysfs for a bridge device. > > Probably could have split up the "virNetDevBridgePort*" from the > virNetDevBridgeSetVlanFiltering - if only to make it a bit cle

Re: [libvirt] [PATCH 1/9] util: new functions for setting bridge and bridge port attributes

2014-11-24 Thread John Ferlan
On 11/24/2014 12:48 PM, Laine Stump wrote: > These functions all set/get items in the sysfs for a bridge device. Probably could have split up the "virNetDevBridgePort*" from the virNetDevBridgeSetVlanFiltering - if only to make it a bit clearer in the commit message that you're adding functions

[libvirt] [PATCH 1/9] util: new functions for setting bridge and bridge port attributes

2014-11-24 Thread Laine Stump
These functions all set/get items in the sysfs for a bridge device. --- src/libvirt_private.syms | 6 ++ src/util/virnetdevbridge.c | 236 - src/util/virnetdevbridge.h | 28 +- 3 files changed, 268 insertions(+), 2 deletions(-) diff --git a/src